[bisq-network/bisq] Add average bsq price (#3212)

chimp1984 notifications at github.com
Fri Sep 6 09:30:42 UTC 2019


chimp1984 commented on this pull request.



> @@ -1022,4 +1050,22 @@ public static void openTxInBsqBlockExplorer(String txId, Preferences preferences
         if (txId != null)
             GUIUtil.openWebPage(preferences.getBsqBlockChainExplorer().txUrl + txId, false);
     }
+
+    public static String getBsqInUsd(Price bsqPrice,

You mean getBSQInUsd instead of getBsqInUsd? In the DAO where it appears often we dont use uppercase. In general we dont use all uppercase (getApiKey not getAPIKey) for  abbreviation as the following Camelcase letter might make the abbreviation harder to read. Of course question of tase and opinon, but code base is follwing that style largely.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3212#discussion_r321653258
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190906/f38ba92b/attachment.html>


More information about the bisq-github mailing list