[bisq-network/bisq] Add average bsq price (#3212)

[Florian Reimair]

freimair requested changes on this pull request.

Please only change stuff that actually changes code behavior. It is really cumbersome to check method signatures and whether they changed or not. Your suggestion contains 10+ method headers that have not changed functionally, but all of them are changes. Please revert those unnecessary changes now and in the future. Thanks!

> @@ -116,7 +116,9 @@ public static Coin getMakerFee(boolean isCurrencyForMakerFeeBtc, @Nullable Coin
      * @param amount
      * @return
      */
-    public static boolean isCurrencyForMakerFeeBtc(Preferences preferences, BsqWalletService bsqWalletService, Coin amount) {
+    public static boolean isCurrencyForMakerFeeBtc(Preferences preferences,
+                                                   BsqWalletService bsqWalletService,
+                                                   Coin amount) {

please only change stuff that actually changes something. Makes it more cumbersome to review...

> @@ -152,7 +154,9 @@ public static Coin getTakerFee(boolean isCurrencyForTakerFeeBtc, @Nullable Coin
         }
     }
 
-    public static boolean isCurrencyForTakerFeeBtc(Preferences preferences, BsqWalletService bsqWalletService, Coin amount) {
+    public static boolean isCurrencyForTakerFeeBtc(Preferences preferences,
+                                                   BsqWalletService bsqWalletService,
+                                                   Coin amount) {

please only change stuff that actually changes something. Makes it cumbersome to review...

> @@ -306,7 +321,9 @@ static Coin getAdjustedAmount(Coin amount, Price price, long maxTradeLimit, int
         }
     }
 
-    public static String getFeeWithFiatAmount(Coin makerFeeAsCoin, Optional<Volume> optionalFeeInFiat, BSFormatter formatter) {
+    public static String getFeeWithFiatAmount(Coin makerFeeAsCoin,
+                                              Optional<Volume> optionalFeeInFiat,
+                                              BSFormatter formatter) {

please only change stuff that actually changes something. Makes it cumbersome to review...

>      private Label marketPriceLabel;
 
     private Coin availableAmount;
-

please only change stuff that actually changes something. Makes it more cumbersome to review...

>      private int gridRow = 0;
 
+

please only change stuff that actually changes something. Makes it more cumbersome to review...

> @@ -122,32 +128,37 @@ private BsqDashboardView(DaoFacade daoFacade,
 
     @Override
     public void initialize() {
-

please only change stuff that actually changes something. Makes it more cumbersome to review...

>      }
 
     private void createKPIs() {
-

please only change stuff that actually changes something. Makes it more cumbersome to review...

>      }
 
-    private void updateBSQPriceData() {
+    private void updateBsqPriceData() {

please only change stuff that actually changes something. Makes it really cumbersome to review...

> @@ -204,8 +214,12 @@ public static void exportAccounts(ArrayList<PaymentAccount> accounts, String fil
         }
     }
 
-    public static void importAccounts(User user, String fileName, Preferences preferences, Stage stage,
-                                      PersistenceProtoResolver persistenceProtoResolver, CorruptedDatabaseFilesHandler corruptedDatabaseFilesHandler) {
+    public static void importAccounts(User user,
+                                      String fileName,
+                                      Preferences preferences,
+                                      Stage stage,
+                                      PersistenceProtoResolver persistenceProtoResolver,
+                                      CorruptedDatabaseFilesHandler corruptedDatabaseFilesHandler) {

please only change stuff that actually changes something. I am stopping at this point because that is too much.

> @@ -189,8 +195,12 @@ public static void showFeeInfoBeforeExecute(Runnable runnable) {
         }
     }
 
-    public static void exportAccounts(ArrayList<PaymentAccount> accounts, String fileName,
-                                      Preferences preferences, Stage stage, PersistenceProtoResolver persistenceProtoResolver, CorruptedDatabaseFilesHandler corruptedDatabaseFilesHandler) {
+    public static void exportAccounts(ArrayList<PaymentAccount> accounts,
+                                      String fileName,
+                                      Preferences preferences,
+                                      Stage stage,
+                                      PersistenceProtoResolver persistenceProtoResolver,
+                                      CorruptedDatabaseFilesHandler corruptedDatabaseFilesHandler) {

please only change stuff that actually changes something. Makes it REALLY cumbersome to review...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3212#pullrequestreview-284756297
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190906/132aa2e0/attachment-0001.html>