[bisq-network/bisq] Optimize some hotspots (#3214)

[sqrrm]

sqrrm commented on this pull request.



> @@ -724,7 +725,8 @@ public void run() {
 
                     NetworkEnvelope networkEnvelope = networkProtoResolver.fromProto(proto);
                     lastReadTimeStamp = now;
-                    log.debug("<< Received networkEnvelope of type: " + networkEnvelope.getClass().getSimpleName());
+                    if (log.isDebugEnabled())
+                        log.debug("<< Received networkEnvelope of type: " + networkEnvelope.getClass().getSimpleName());
 

It looks like it will have to do that call to `getSimpleName()` but not build the string at debug log level. I think that's an acceptable balance so I change my opinion and would go with what @freimair suggests.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3214#discussion_r321674097
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190906/1a9f68eb/attachment-0001.html>