[bisq-network/bisq] Add mediation support (#3221)

chimp1984 notifications at github.com
Fri Sep 6 21:38:05 UTC 2019


For testing trade period half over and trade period over popups and states I added a keyboard shortcut: cmd + up for going from first half -> second half -> trade period over and cmd + down for the other direction. It only shows state changes when not in mediation or dispute mode. But after a change and a restart a period warning popup is displayed.
This dev test feature is only active for v 1.1.5, but code should be removed before release.

I set the activation dates in OfferRestrictions and MediationManager to 1st of september, so mediation is fully activated. For release we need to set date for OfferRestrictions 3-5 days after release date (after that date not updated users cannot take an offer and their offers will be filtered by updated nodes). We will set additionally a filter to enforce update. That shows a popup for updating as well.
Activation date in MediationManager is the date when the mediation will be enabled. Before that opening a dispute will open arbitration. We should set taht data about 1 week after OfferRestrictions.REQUIRE_UPDATE_DATE so that pending trades get completed and to avoid mixed cases where one peer opens mediation with new version but old opens arbitration with old version.

This PR is a huge code change and all the tradeprotocol, mediation, arbitration and trade chat need to be tested very carefully. There are many possible variations. I will test over the weekend further so monday it should be battletested from my side.

For reviewing the PR I recommend to read the full tradeprotocol, mediation, arbitration and trade chat domain. Too many chnages that it is feasible to go from commit to commit...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3221#issuecomment-529022641
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190906/d334d931/attachment.html>


More information about the bisq-github mailing list