[bisq-network/bisq] Add mediation support (#3221)

chimp1984 notifications at github.com
Sat Sep 7 15:41:11 UTC 2019


chimp1984 commented on this pull request.



> @@ -44,6 +44,7 @@ message NetworkEnvelope {
 
         OpenNewDisputeMessage open_new_dispute_message = 22;
         PeerOpenedDisputeMessage peer_opened_dispute_message = 23;
+        // ChatMessage in java class. We cannot rename protobuf definition because it would break backward compatibility

I just tested it. With pure network messages the class and field name are irrelevant, so yes in that case we can rename it. I will make a commit later.
Though we have to take care to not do that on protobuf objects which are peristed (or used in both network and peristence context) as locally stored data would break then.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3221#discussion_r321973619
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190907/db2b0260/attachment.html>


More information about the bisq-github mailing list