[bisq-network/bisq] periodical UpdateDataReq for Seednodes (#3202)

Florian Reimair notifications at github.com
Mon Sep 9 06:29:51 UTC 2019


freimair commented on this pull request.



> @@ -208,7 +208,7 @@ else if (networkEnvelope instanceof RemoveDataMessage)
                     final Set<ProtectedStorageEntry> dataSet = getDataResponse.getDataSet();
                     Set<PersistableNetworkPayload> persistableNetworkPayloadSet = getDataResponse.getPersistableNetworkPayloadSet();
 
-                    if (log.isDebugEnabled()) logContents(networkEnvelope, dataSet, persistableNetworkPayloadSet);
+                    if (log.isInfoEnabled()) logContents(networkEnvelope, dataSet, persistableNetworkPayloadSet);

Firstly, I do not agree that the information is very important. It is just numbers. To be exact, it is number of how many messages of each type arrive after a Preliminary- or UpdateDataRequest. Users only get poorer performance and a bigger log file out of that.

Secondly, if you enable "DEBUG log verbosity" (I assume that is what you meant), INFO is enabled as well. The logging behavior does not change, only the block of undocumented logging code is moved out of the way so one can see the functional code faster.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3202#discussion_r322080380
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190908/ede66c6c/attachment.html>


More information about the bisq-github mailing list