[bisq-network/bisq] [WIP] Add new payment method: Japan Bank Transfer (furikomi) (#3225)

[Christoph Atteneder]

ripcurlx requested changes on this pull request.

NACK - Although it wasn't up for review - here some minor change suggestions. @wiz Do you plan to open this PR for public review soon?

> @@ -2804,6 +2804,17 @@ payment.f2f.info.openURL=Open web page
 payment.f2f.offerbook.tooltip.countryAndCity=Country and city: {0} / {1}
 payment.f2f.offerbook.tooltip.extra=Additional information: {0}
 
+# Japan Bank Transfer
+payment.japan.bank=Bank or Financial Institution
+payment.japan.bank.select=Search for Financial Institution
+payment.japan.bank.code=Bank Code

To prevent unnecessary translations you could use `payment.bankCode` instead.

> @@ -2804,6 +2804,17 @@ payment.f2f.info.openURL=Open web page
 payment.f2f.offerbook.tooltip.countryAndCity=Country and city: {0} / {1}
 payment.f2f.offerbook.tooltip.extra=Additional information: {0}
 
+# Japan Bank Transfer
+payment.japan.bank=Bank or Financial Institution
+payment.japan.bank.select=Search for Financial Institution
+payment.japan.bank.code=Bank Code
+payment.japan.bank.name=Bank Name

To prevent unnecessary translations you could use `payment.bank.name` instead.

> @@ -2804,6 +2804,17 @@ payment.f2f.info.openURL=Open web page
 payment.f2f.offerbook.tooltip.countryAndCity=Country and city: {0} / {1}
 payment.f2f.offerbook.tooltip.extra=Additional information: {0}
 
+# Japan Bank Transfer
+payment.japan.bank=Bank or Financial Institution
+payment.japan.bank.select=Search for Financial Institution
+payment.japan.bank.code=Bank Code
+payment.japan.bank.name=Bank Name
+payment.japan.bank.branch.code=Branch Code
+payment.japan.bank.branch.name=Branch Name
+payment.japan.bank.account.number=Account Number

To prevent unnecessary translations you could use `payment.account.no` instead.

> @@ -2804,6 +2804,17 @@ payment.f2f.info.openURL=Open web page
 payment.f2f.offerbook.tooltip.countryAndCity=Country and city: {0} / {1}
 payment.f2f.offerbook.tooltip.extra=Additional information: {0}
 
+# Japan Bank Transfer
+payment.japan.bank=Bank or Financial Institution
+payment.japan.bank.select=Search for Financial Institution
+payment.japan.bank.code=Bank Code
+payment.japan.bank.name=Bank Name
+payment.japan.bank.branch.code=Branch Code
+payment.japan.bank.branch.name=Branch Name
+payment.japan.bank.account.number=Account Number
+payment.japan.bank.account.name=Account Name

To prevent unnecessary translations you could use `payment.account.name` instead.

> @@ -2804,6 +2804,17 @@ payment.f2f.info.openURL=Open web page
 payment.f2f.offerbook.tooltip.countryAndCity=Country and city: {0} / {1}
 payment.f2f.offerbook.tooltip.extra=Additional information: {0}
 
+# Japan Bank Transfer
+payment.japan.bank=Bank or Financial Institution
+payment.japan.bank.select=Search for Financial Institution
+payment.japan.bank.code=Bank Code
+payment.japan.bank.name=Bank Name
+payment.japan.bank.branch.code=Branch Code
+payment.japan.bank.branch.name=Branch Name
+payment.japan.bank.account.number=Account Number
+payment.japan.bank.account.name=Account Name
+payment.japan.bank.account.type=Account Type
+payment.japan.bank.account.type.select=Account Type

To prevent unnecessary translations you could use `payment.select.account` instead.

> @@ -2804,6 +2804,17 @@ payment.f2f.info.openURL=Open web page
 payment.f2f.offerbook.tooltip.countryAndCity=Country and city: {0} / {1}
 payment.f2f.offerbook.tooltip.extra=Additional information: {0}
 
+# Japan Bank Transfer
+payment.japan.bank=Bank or Financial Institution
+payment.japan.bank.select=Search for Financial Institution
+payment.japan.bank.code=Bank Code
+payment.japan.bank.name=Bank Name
+payment.japan.bank.branch.code=Branch Code
+payment.japan.bank.branch.name=Branch Name
+payment.japan.bank.account.number=Account Number
+payment.japan.bank.account.name=Account Name
+payment.japan.bank.account.type=Account Type

To prevent unnecessary translations you could use `payment.accountType` instead.

> @@ -2804,6 +2804,17 @@ payment.f2f.info.openURL=Open web page
 payment.f2f.offerbook.tooltip.countryAndCity=Country and city: {0} / {1}
 payment.f2f.offerbook.tooltip.extra=Additional information: {0}
 
+# Japan Bank Transfer
+payment.japan.bank=Bank or Financial Institution
+payment.japan.bank.select=Search for Financial Institution
+payment.japan.bank.code=Bank Code
+payment.japan.bank.name=Bank Name
+payment.japan.bank.branch.code=Branch Code

We do have a `payment.branchNr` -> Branch no., but I'm not sure if it is the perfect replacement in that case.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3225#pullrequestreview-285328264
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190909/7e9c3c98/attachment-0001.html>