[bisq-network/bisq] periodical UpdateDataReq for Seednodes (#3202)

Florian Reimair notifications at github.com
Tue Sep 10 11:34:19 UTC 2019


freimair commented on this pull request.



> @@ -336,12 +337,11 @@ public void onPreliminaryDataReceived() {
 
     @Override
     public void onUpdatedDataReceived() {
-        if (!isBootstrapped) {
-            isBootstrapped = true;
-            maybeProcessAllMailboxEntries();
-            p2pServiceListeners.stream().forEach(P2PServiceListener::onUpdatedDataReceived);
+        isBootstrapped = true;
+        maybeProcessAllMailboxEntries();
+        p2pServiceListeners.stream().forEach(P2PServiceListener::onUpdatedDataReceived);
+        if(!isBootstrapped)
             p2PDataStorage.onBootstrapComplete();

I am running a long-time test with the original code. It seems that everything works just fine without the change. God I love when minor changes somewhere in core change the behavior elsewhere without any trace :).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3202#discussion_r322691099
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190910/6f8686ba/attachment.html>


More information about the bisq-github mailing list