[bisq-network/bisq] Dissolve BSFormatter (#3230)

battleofwizards notifications at github.com
Tue Sep 10 13:16:29 UTC 2019


Thanks a lot for attempting this code refactoring!

I cannot say for actual reviewers (ripcurlx, sqrrm, freimar, ManfredKarrer) but here are my 5 cents. Context: I am a new contributor myself so please don't put to much weight into my comments.

1) The "Optimize Imports" commit is huge and serious enough for being a PR on its own. Whether this will be welcome by other developers I don't know. Please seek advice on #dev channel. Personally I would very much welcome this (but first we need to make sure import optimization feature is stable across IntelliJ installations).

2) The remaining changes should be probably split into smaller PR-s that are easy for reviewers and do feel safe. Yes, that may be a pain from the productivity point of view. Being "reviewer friendly" is a priority though.

Hope this helps!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3230#issuecomment-529929377
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190910/0f1718d3/attachment.html>


More information about the bisq-github mailing list