[bisq-network/bisq] Dissolve BSFormatter (#3230)

sqrrm notifications at github.com
Tue Sep 10 18:27:33 UTC 2019


@battleofwizards on the topic of reviewers. I think the task of reviewing is up to everyone contributing to the project. I see the maintainer role, ie, merge rights, as just a 'click the merge button when the PR has enough ACKs' kind of job. I will try to review PRs as I can and will merge when I see PRs with ACKs from reputable contributors and no NACKs.

On your other points I agree, in particular making PRs easy to review is in the PR creator's own interest. If it's too hard I will likely prioritize other easier to review PRs.

@bodymindarts I think most developers use intellij so to me it's not unreasonable to optimize imports and do other formatting by intellij.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3230#issuecomment-530062402
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190910/13137be5/attachment-0001.html>


More information about the bisq-github mailing list