[bisq-network/bisq] Make stateless BSFormatter functions static and remove dead code (#3239)

[Justin Carter]

Making these functions static is a preparation for extraction.

Reducing the public interface of the BSFormatter instances reduces coupling and enables moving these functions to places where it makes more sense for them to live.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3239

-- Commit Summary --

  * Make stateless BSFormatter functions static and remove dead code

-- File Changes --

    M .idea/codeStyles/codeStyleConfig.xml (1)
    M core/src/main/java/bisq/core/app/WalletAppSetup.java (2)
    M core/src/main/java/bisq/core/dao/presentation/DaoUtil.java (10)
    M core/src/main/java/bisq/core/dao/state/DaoStateService.java (3)
    M core/src/main/java/bisq/core/notifications/alerts/market/MarketAlerts.java (4)
    M core/src/main/java/bisq/core/notifications/alerts/price/PriceAlert.java (4)
    M core/src/main/java/bisq/core/util/BSFormatter.java (148)
    M desktop/src/main/java/bisq/desktop/components/PeerInfoIcon.java (4)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/PaymentMethodForm.java (2)
    M desktop/src/main/java/bisq/desktop/main/Chat/Chat.java (2)
    M desktop/src/main/java/bisq/desktop/main/MainViewModel.java (4)
    M desktop/src/main/java/bisq/desktop/main/account/content/notifications/ManageMarketAlertsWindow.java (2)
    M desktop/src/main/java/bisq/desktop/main/account/content/notifications/MobileNotificationsView.java (20)
    M desktop/src/main/java/bisq/desktop/main/dao/bonding/BondingViewUtils.java (4)
    M desktop/src/main/java/bisq/desktop/main/dao/bonding/bonds/BondListItem.java (3)
    M desktop/src/main/java/bisq/desktop/main/dao/bonding/reputation/MyReputationListItem.java (3)
    M desktop/src/main/java/bisq/desktop/main/dao/bonding/roles/RoleDetailsWindow.java (3)
    M desktop/src/main/java/bisq/desktop/main/dao/burnbsq/proofofburn/MyProofOfBurnListItem.java (3)
    M desktop/src/main/java/bisq/desktop/main/dao/burnbsq/proofofburn/ProofOfBurnListItem.java (3)
    M desktop/src/main/java/bisq/desktop/main/dao/governance/proposals/ProposalsView.java (2)
    M desktop/src/main/java/bisq/desktop/main/dao/governance/result/VoteResultView.java (3)
    M desktop/src/main/java/bisq/desktop/main/dao/wallet/tx/BsqTxView.java (7)
    M desktop/src/main/java/bisq/desktop/main/disputes/trader/TraderDisputeView.java (12)
    M desktop/src/main/java/bisq/desktop/main/funds/locked/LockedView.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/reserved/ReservedView.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionsListItem.java (2)
    M desktop/src/main/java/bisq/desktop/main/market/MarketView.java (6)
    M desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartView.java (8)
    M desktop/src/main/java/bisq/desktop/main/market/spread/SpreadViewModel.java (2)
    M desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsView.java (12)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferView.java (4)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java (30)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookView.java (10)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookViewModel.java (8)
    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferView.java (4)
    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferViewModel.java (4)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/ContractWindow.java (8)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/DisputeSummaryWindow.java (10)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/OfferDetailsWindow.java (12)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/ProposalResultsWindow.java (3)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/TradeDetailsWindow.java (10)
    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesViewModel.java (6)
    M desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferViewModel.java (2)
    M desktop/src/main/java/bisq/desktop/main/portfolio/failedtrades/FailedTradesViewModel.java (6)
    M desktop/src/main/java/bisq/desktop/main/portfolio/openoffer/OpenOffersViewModel.java (8)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java (2)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java (8)
    M desktop/src/main/java/bisq/desktop/main/presentation/MarketPricePresentation.java (8)
    M desktop/src/main/java/bisq/desktop/main/settings/network/NetworkSettingsView.java (4)
    M desktop/src/main/java/bisq/desktop/main/settings/network/P2pNetworkListItem.java (6)
    M desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java (11)
    M desktop/src/main/java/bisq/desktop/util/GUIUtil.java (2)
    M desktop/src/main/java/bisq/desktop/util/validation/SecurityDepositValidator.java (8)
    M desktop/src/test/java/bisq/desktop/util/BSFormatterTest.java (48)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3239.patch
https://github.com/bisq-network/bisq/pull/3239.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3239
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190910/bf1e7c13/attachment-0001.html>