[bisq-network/bisq] Remove / refactor BSFormatter (tracking issue) (#3240)

[Justin Carter]

While making myself familiar with the code and thinking about improvements I kept seeing complexities connected to the [BSFormatter]() class.

The code base is quite tangled up and that class is one of the places that contributes because:
- it is bucket class with many many unrelated functions
- it has a _huge_ public interface even though most functions don't depend on instance state
- it depends on globals
- it is depended on by many classes
- it is part of a type hierarchy

This led me to refactor it out of existence. The final state of the code is [here](https://github.com/bisq-network/bisq/pull/3230) but it is too much to review and merge in 1 step.
To get the code changes in I can break it down into 5-6 trivial commits / PRs, but don't want to do this work unless other ppl agree that removing this class makes sense.
Please give 👍 or 👎 as feedback on wether I should go ahead. Perhaps I am the only one who has seen these issues, or they aren't hurting anyone and the code can stay as is. In that case I don't want to make the effort.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3240
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190910/94f9ccff/attachment.html>