[bisq-network/bisq] Make stateless BSFormatter functions static and remove dead code (#3239)

[Florian Reimair]

freimair requested changes on this pull request.

thanks for splitting that up. yet, I found another LOC I need you to change.

Other than that, I agree with both of you.
- christoph: the full advantages will only show once alle BSFormatter-Stuff is gone from the constructors.
- bodymindarts: reducing the API is useful as well as removing dead code
nothing is perfect.

please refer the followup PR to this one and we are good.



> @@ -1,5 +1,6 @@
 <component name="ProjectCodeStyleConfiguration">
   <state>
     <option name="USE_PER_PROJECT_SETTINGS" value="true" />
+    <option name="PREFERRED_PROJECT_CODE_STYLE" value="Default" />

```suggestion

```

that gets me as well every time. Had it solved temporarily by doing https://github.com/bisq-network/bisq/pull/3205, yet, it just reappeared again.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3239#pullrequestreview-286694745
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190911/efe1d056/attachment.html>