[bisq-network/bisq] Extract helper classes from BSFormatter (#3244)

[Justin Carter]

Next step in removing BSFormatter. Here I extract 2 classes.

DisplayUtils which lives in the desktop project and has all methods that are only used in desktop. This is to reduce the number of dependencies going from desktop -> core.

ParsingUtils which has all the parsing related methods (ie is not formatting).
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3244

-- Commit Summary --

  * Extract DisplayUtils from BSFormatter
  * Extract parsing functions from BSFormatter to ParsingUtils

-- File Changes --

    M core/src/main/java/bisq/core/dao/state/DaoStateService.java (4)
    M core/src/main/java/bisq/core/monetary/Altcoin.java (4)
    M core/src/main/java/bisq/core/monetary/Price.java (4)
    M core/src/main/java/bisq/core/monetary/Volume.java (4)
    M core/src/main/java/bisq/core/notifications/alerts/market/MarketAlerts.java (2)
    M core/src/main/java/bisq/core/offer/OfferUtil.java (11)
    M core/src/main/java/bisq/core/util/BSFormatter.java (337)
    M core/src/main/java/bisq/core/util/BsqFormatter.java (22)
    A core/src/main/java/bisq/core/util/ParsingUtils.java (83)
    M desktop/src/main/java/bisq/desktop/components/PeerInfoIcon.java (5)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/PaymentMethodForm.java (3)
    M desktop/src/main/java/bisq/desktop/main/Chat/Chat.java (3)
    M desktop/src/main/java/bisq/desktop/main/MainView.java (5)
    M desktop/src/main/java/bisq/desktop/main/MainViewModel.java (5)
    M desktop/src/main/java/bisq/desktop/main/account/content/notifications/MobileNotificationsView.java (11)
    M desktop/src/main/java/bisq/desktop/main/dao/bonding/bonds/BondListItem.java (5)
    M desktop/src/main/java/bisq/desktop/main/dao/bonding/reputation/MyReputationListItem.java (5)
    M desktop/src/main/java/bisq/desktop/main/dao/bonding/reputation/MyReputationView.java (3)
    M desktop/src/main/java/bisq/desktop/main/dao/bonding/roles/RoleDetailsWindow.java (4)
    M desktop/src/main/java/bisq/desktop/main/dao/burnbsq/assetfee/AssetFeeView.java (3)
    M desktop/src/main/java/bisq/desktop/main/dao/burnbsq/proofofburn/MyProofOfBurnListItem.java (5)
    M desktop/src/main/java/bisq/desktop/main/dao/burnbsq/proofofburn/ProofOfBurnListItem.java (5)
    M desktop/src/main/java/bisq/desktop/main/dao/burnbsq/proofofburn/ProofOfBurnView.java (3)
    M desktop/src/main/java/bisq/desktop/main/dao/economy/dashboard/BsqDashboardView.java (2)
    M desktop/src/main/java/bisq/desktop/main/dao/governance/make/MakeProposalView.java (5)
    M desktop/src/main/java/bisq/desktop/main/dao/governance/proposals/ProposalsView.java (6)
    M desktop/src/main/java/bisq/desktop/main/dao/governance/result/VoteResultView.java (4)
    M desktop/src/main/java/bisq/desktop/main/dao/wallet/send/BsqSendView.java (3)
    M desktop/src/main/java/bisq/desktop/main/dao/wallet/tx/BsqTxView.java (8)
    M desktop/src/main/java/bisq/desktop/main/disputes/arbitrator/ArbitratorDisputeView.java (3)
    M desktop/src/main/java/bisq/desktop/main/disputes/trader/TraderDisputeView.java (9)
    M desktop/src/main/java/bisq/desktop/main/funds/deposit/DepositView.java (5)
    M desktop/src/main/java/bisq/desktop/main/funds/locked/LockedView.java (3)
    M desktop/src/main/java/bisq/desktop/main/funds/reserved/ReservedView.java (3)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionsListItem.java (3)
    M desktop/src/main/java/bisq/desktop/main/funds/withdrawal/WithdrawalView.java (3)
    M desktop/src/main/java/bisq/desktop/main/market/MarketView.java (11)
    M desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartViewModel.java (5)
    M desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsView.java (19)
    M desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsViewModel.java (7)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java (4)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java (35)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookView.java (3)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookViewModel.java (7)
    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferViewModel.java (15)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/ContractWindow.java (13)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/DisputeSummaryWindow.java (24)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/OfferDetailsWindow.java (25)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/ProposalResultsWindow.java (4)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/TradeDetailsWindow.java (17)
    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesView.java (5)
    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesViewModel.java (11)
    M desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferViewModel.java (4)
    M desktop/src/main/java/bisq/desktop/main/portfolio/failedtrades/FailedTradesViewModel.java (9)
    M desktop/src/main/java/bisq/desktop/main/portfolio/openoffer/OpenOffersViewModel.java (11)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java (7)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java (5)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep2View.java (3)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/seller/SellerStep3View.java (3)
    M desktop/src/main/java/bisq/desktop/main/settings/network/P2pNetworkListItem.java (4)
    M desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java (3)
    A desktop/src/main/java/bisq/desktop/util/DisplayUtils.java (292)
    M desktop/src/main/java/bisq/desktop/util/validation/BsqValidator.java (11)
    M desktop/src/main/java/bisq/desktop/util/validation/NumberValidator.java (4)
    M desktop/src/main/java/bisq/desktop/util/validation/SecurityDepositValidator.java (5)
    M desktop/src/test/java/bisq/desktop/util/BSFormatterTest.java (101)
    A desktop/src/test/java/bisq/desktop/util/DisplayUtilsTest.java (132)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3244.patch
https://github.com/bisq-network/bisq/pull/3244.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3244
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190911/1a28d1e0/attachment-0001.html>