[bisq-network/bisq] Reduce bs formatter interface (#3253)

[Justin Carter]

Part 3 of my ongoing refactoring to remove BSFormatter.

This is the last refactoring that deals with method extraction. Next step will be to extract the CoinFormatter interface to deal with the polymorphism between BsFormatter and BsqFormatter.

Tracking issue: https://github.com/bisq-network/bisq/issues/3240
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3253

-- Commit Summary --

  * Extract FormattingUtils from BSFormatter
  * Remove dead Code from BSFormatter
  * Move Currency related helpers out of BSFormatter to CurrencyUtils
  * Move functions that only have 1 call-site out of BSFormatter

-- File Changes --

    M core/src/main/java/bisq/core/app/WalletAppSetup.java (3)
    M core/src/main/java/bisq/core/dao/presentation/DaoUtil.java (11)
    M core/src/main/java/bisq/core/locale/CurrencyUtil.java (25)
    M core/src/main/java/bisq/core/notifications/alerts/market/MarketAlerts.java (7)
    M core/src/main/java/bisq/core/notifications/alerts/price/PriceAlert.java (5)
    M core/src/main/java/bisq/core/util/BSFormatter.java (378)
    M core/src/main/java/bisq/core/util/BsqFormatter.java (16)
    A core/src/main/java/bisq/core/util/FormattingUtils.java (280)
    M core/src/main/java/bisq/core/util/ParsingUtils.java (2)
    A core/src/test/java/bisq/core/util/FormattingUtilsTest.java (69)
    M desktop/src/main/java/bisq/desktop/components/ColoredDecimalPlacesWithZerosText.java (9)
    M desktop/src/main/java/bisq/desktop/main/account/content/notifications/ManageMarketAlertsWindow.java (3)
    M desktop/src/main/java/bisq/desktop/main/account/content/notifications/MobileNotificationsView.java (11)
    M desktop/src/main/java/bisq/desktop/main/dao/bonding/BondingViewUtils.java (5)
    M desktop/src/main/java/bisq/desktop/main/dao/economy/dashboard/BsqDashboardView.java (3)
    M desktop/src/main/java/bisq/desktop/main/dao/governance/result/CycleListItem.java (3)
    M desktop/src/main/java/bisq/desktop/main/disputes/trader/TraderDisputeView.java (4)
    M desktop/src/main/java/bisq/desktop/main/market/MarketView.java (10)
    M desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartView.java (9)
    M desktop/src/main/java/bisq/desktop/main/market/spread/SpreadViewModel.java (3)
    M desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsView.java (15)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferView.java (4)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java (25)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookView.java (8)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookViewModel.java (20)
    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferView.java (4)
    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferViewModel.java (7)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/ContractWindow.java (3)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/DisputeSummaryWindow.java (3)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/OfferDetailsWindow.java (18)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/TradeDetailsWindow.java (3)
    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesViewModel.java (8)
    M desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferViewModel.java (7)
    M desktop/src/main/java/bisq/desktop/main/portfolio/failedtrades/FailedTradesViewModel.java (6)
    M desktop/src/main/java/bisq/desktop/main/portfolio/openoffer/OpenOffersViewModel.java (8)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java (3)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java (32)
    M desktop/src/main/java/bisq/desktop/main/presentation/MarketPricePresentation.java (9)
    M desktop/src/main/java/bisq/desktop/main/settings/network/NetworkSettingsView.java (5)
    M desktop/src/main/java/bisq/desktop/main/settings/network/P2pNetworkListItem.java (5)
    M desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java (9)
    M desktop/src/main/java/bisq/desktop/util/DisplayUtils.java (25)
    M desktop/src/main/java/bisq/desktop/util/GUIUtil.java (3)
    M desktop/src/main/java/bisq/desktop/util/validation/SecurityDepositValidator.java (5)
    M desktop/src/test/java/bisq/desktop/util/BSFormatterTest.java (41)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3253.patch
https://github.com/bisq-network/bisq/pull/3253.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3253
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190913/44bd6036/attachment.html>