[bisq-network/bisq] Update MobileModel parseDescriptor to support iPhone 11 (#3277)
Devin Bileck
notifications at github.com
Tue Sep 17 07:17:10 UTC 2019
It was parsing only the first digit of the version and using that in a
comparison check to determine if the version is greater than 5.
This meant for the iPhone 11 it was comparing 1 > 5, returning an
incorrect result.
It now supports multi-digit version numbers (i.e. 11), including
support for a suffix in the version (i.e. 11S), just in case...
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/3277
-- Commit Summary --
* Update MobileModel parseDescriptor to support iPhone 11
-- File Changes --
M core/src/main/java/bisq/core/notifications/MobileModel.java (18)
M core/src/test/java/bisq/core/notifications/MobileModelTest.java (11)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/3277.patch
https://github.com/bisq-network/bisq/pull/3277.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3277
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190917/50611322/attachment-0001.html>
More information about the bisq-github
mailing list