[bisq-network/bisq] Remove reactfx dependency (#3279)

battleofwizards notifications at github.com
Tue Sep 17 13:49:42 UTC 2019


The reactfx was a 0.33MB dependency / 238 Java source files.

We only used it for FxTimer helper and to measure FPS in development mode.

The small FxTimer class got copied over into the project, so there is no change in semantics.

The FPS measurement got replaced w/ com.sun.javafx.perf.PerformanceTracker, an internal but long stable part of JavaFx. This is probably not a problem, because it only concerns a rarely used, developer feature.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3279

-- Commit Summary --

  * Remove reactfx dependency

-- File Changes --

    M build.gradle (2)
    A common/src/main/java/bisq/common/reactfx/FxTimer.java (104)
    A common/src/main/java/bisq/common/reactfx/README.md (6)
    A common/src/main/java/bisq/common/reactfx/Timer.java (66)
    M desktop/src/main/java/bisq/desktop/app/BisqApp.java (18)
    M desktop/src/main/java/bisq/desktop/common/UITimer.java (5)
    M gradle/witness/gradle-witness.gradle (1)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3279.patch
https://github.com/bisq-network/bisq/pull/3279.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3279
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190917/10e0b941/attachment.html>


More information about the bisq-github mailing list