[bisq-network/bisq] Update MobileModel parseDescriptor to support iPhone 11 (#3277)

Christoph Atteneder notifications at github.com
Tue Sep 17 15:26:22 UTC 2019


ripcurlx commented on this pull request.



>                          return true;
+                    }
+                    if (versionString.matches("\\d[^\\d]")) {
+                        versionString = versionString.substring(0, 1);
+                    } else if (versionString.matches("\\d{2}[^\\d]")) {
+                        versionString = versionString.substring(0, 2);
+                    }
                     try {
                         int version = Integer.parseInt(versionString);
                         return version > 5;

Yes, I looks like as if the check is wrong. Even if the hardware string is used it must be even higher (iPhone9,1+ == iPhone 7). Maybe @joachimneumann could shed some light on this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3277#discussion_r325234764
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190917/8098b731/attachment.html>


More information about the bisq-github mailing list