[bisq-network/bisq] Fulfilling Proposal #110 (#3275)

[niyid]

> Hi @niyid, thanks a lot for working on this!
> 
> My fear is that this great effort may stuck in limbo simply because of the sheer volume of changes.
> 
> Of course, this is inherently a big feature. However, there is virtually always a way to split into smaller, thinner "features", even if they are artificial. In modern software engineering, individual pull requests should be pieces of work on the order of hour(s) to 2-3 days max. In no case many weeks of active coding should be merged at once.

Thanks @battleofwizards 

I acknowledge the volume of work that has been done. But I had to also separate the delivery to units otherwise I would still not have done a PR yet. This PR is simply the Monero Wallet UI without any integration to Bisq trades. That is the next unit I am delivering hopefully before the end of this cycle.

Also, the only thing keeping this in limbo right now is the monero-wallet-rpc library which I am working on to play nicely with Gradle (as it is on Maven). The project has been completely merged and rebased and good to go.

Once again, thanks for the nice words.

Regards.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3275#issuecomment-532396695
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190917/4b7b6b9c/attachment.html>