[bisq-network/bisq] Fulfilling Proposal #110 (#3275)

niyid notifications at github.com
Tue Sep 17 22:22:40 UTC 2019


I understand your concern perfectly. With that in mind, it will not make a
difference if the code is included directly (which is the quick fix I am
considering right now).

On Tue, Sep 17, 2019 at 11:18 PM wiz <notifications at github.com> wrote:

> Yeah, just to give you an idea, we had a dev call yesterday about adding
> API into Bisq. There has been consensus to add an API into Bisq for 2
> years, but the PR has still not been approved because it wants to add jar
> deps. I made the argument that a single jar dep could be accepted if it's
> published by a large trustworthy organization such as Google (in the case
> of protobuf) or Square (in the case of their http jar). But you guys
> publishing your own jar could be interpreted as an attempt to sneak code
> into Bisq, so please understand why this needs to be included as part of
> the PR (and then still might be rejected for other reasons)
>
>> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/bisq-network/bisq/pull/3275?email_source=notifications&email_token=AE2MWRZXFZFPQQRPLNMWHHLQKFJSRA5CNFSM4IXG65PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD66CKAI#issuecomment-532423937>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AE2MWR6NA6WCRXIN3TP2JGDQKFJSRANCNFSM4IXG65PA>
> .
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3275#issuecomment-532425135
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190917/e0f0e9b0/attachment-0001.html>


More information about the bisq-github mailing list