[bisq-network/bisq] Remove controlsfx dependency (#3287)

[battleofwizards]

The `controlsfx` is a huge JavaFX components library (0.83MB as JAR) offering a number of advanced components.

Turns out, we only use a single component, the `PopOver`. Fortunately, the `PopOver` is self-contained and easy to pull out from `controlsfx`.

This PR embeds the `PopOver` in the project and removes `controlsfx` dependency. The embedded version is exactly the same as previously used in the project, so no change in semantics should occur.

Note for reviewers: see README.md for exact versions and links to files that were copied over. No new code is introduced. The easiest way to verify is to diff the embedded vs external (3 files total).
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3287

-- Commit Summary --

  * Remove controlsfx dependency

-- File Changes --

    M build.gradle (2)
    M desktop/src/main/java/bisq/desktop/components/AutoTooltipTableColumn.java (3)
    M desktop/src/main/java/bisq/desktop/components/InfoAutoTooltipLabel.java (3)
    M desktop/src/main/java/bisq/desktop/components/InfoInputTextField.java (3)
    M desktop/src/main/java/bisq/desktop/components/InfoTextField.java (3)
    M desktop/src/main/java/bisq/desktop/components/InputTextField.java (3)
    A desktop/src/main/java/bisq/desktop/components/controlsfx/README.md (13)
    A desktop/src/main/java/bisq/desktop/components/controlsfx/control/PopOver.java (787)
    A desktop/src/main/java/bisq/desktop/components/controlsfx/control/popover.css (36)
    A desktop/src/main/java/bisq/desktop/components/controlsfx/skin/PopOverSkin.java (693)
    M gradle/witness/gradle-witness.gradle (1)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3287.patch
https://github.com/bisq-network/bisq/pull/3287.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3287
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190918/72feb24a/attachment.html>