[bisq-network/bisq] Fulfilling Proposal #110 (#3275)
battleofwizards
notifications at github.com
Wed Sep 18 10:31:01 UTC 2019
The `monero-java` is a sophisticated project on its own with **18K+ Java LOC** and **1.5K C++ LOC**.
Also it's not like we only need 2% of this that we could maybe pull and embed directly into Bisq. We need roughly the whole thing.
So I suggest against embedding `monero-java` into Bisq. If we agree to use it then it should be external dependency fully verified with gradle witness.
I also want to reiterate what I already said. This PR is way too big. The initial step should be maybe just correctly referencing `monero-java` in a safe and cross-platform manner with any trivial/example usage of this in a developer mode.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3275#issuecomment-532624996
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190918/9465568c/attachment.html>
More information about the bisq-github
mailing list