[bisq-network/bisq] Fulfilling Proposal #110 (#3275)
woodser
notifications at github.com
Wed Sep 18 14:57:45 UTC 2019
@niyid
Wouldn't you end up essentially re-writing MoneroWalletRpc.java? The only thing extra that class does is translates monero-wallet-rpc's hodgepodge API to a clear model definition intended for long term use. The purpose of the library is to avoid the need for application developers to roll their own binding with non-uniform APIs. The library already provides extensive tests, a clear model definition, multisignature support, and the ability to switch to a native wallet binding with the same API. I do not see why we would not use that as a matter of code review.
I am working on uploading the `monero-java` project to the Maven repository. I can change the POM to package the project as POM instead of JAR, if that would be useful.
FYI we're on Bisq's Slack workspace.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3275#issuecomment-532723802
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190918/f62780d8/attachment.html>
More information about the bisq-github
mailing list