[bisq-network/bisq] Fulfilling Proposal #110 (#3275)

[niyid]

> @niyid
> 
> Wouldn't you end up essentially re-writing MoneroWalletRpc.java? The only thing extra that class does is translates monero-wallet-rpc's hodgepodge API to a clear model definition intended for long term use. The purpose of the library is to avoid the need for application developers to roll their own binding with non-uniform APIs. The library already provides extensive tests, a clear model definition, multisignature support, and the ability to switch to a native wallet binding with the same API. I do not see why we would not use that as a matter of code review.
> 
> I am working on uploading the `monero-java` project to the Maven repository. I can change the POM to package the project as POM instead of JAR, if that would be useful.
> 
> FYI we're on Bisq's Slack workspace.

@woodser 

As I already pointed out, I am quite with the inclusion of **`monero-java`** as a library even if with respect to the current goal (which is to have a bridge to **`monero-wallet-rpc`**. I was also of the naive opinion that it will be accepted without a code review based on your role on Bisq. The **`monero-java`** is no doubt a robust library that provides the current needs with respect to the goal of the current PR and proposal. While many of the extensive functionality of **`monero-java`** may not be in use at the moment, they may prove very useful in the near and far future.

But with the requirement of a code review being placed on **`monero-java`**, this PR is dead in the water as I do not see how 2 or 3 people can review a project of tens of thousands of files and functions within a reasonable time.

On the matter of rewriting `MoneroWalletRpc.java`, not at all. It is too robust for what I have in mind as it even references `MoneroWalletDaemon`.

I will join you on Bisq Slack soon.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3275#issuecomment-532731541
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190918/e6a8b42f/attachment.html>