[bisq-network/bisq] chop down long chained calls and force brackets on if (#3296)

chimp1984 notifications at github.com
Thu Sep 19 14:48:27 UTC 2019


NACK

Actually it does not behave as i would like:

If its not a long line it makes it a one-liner. I prefer linebreaks at all non-trivial stream expressions for better redibility.
```
 public Optional<TxOutput> getLockupTxOutput(String txId) {
        return getTx(txId).flatMap(tx -> tx.getTxOutputs().stream().filter(this::isLockupOutput).findFirst());
    }
```

```
   public Optional<TxOutput> getLockupTxOutput(String txId) {
        return getTx(txId).flatMap(tx -> tx.getTxOutputs().stream()
                .filter(this::isLockupOutput)
                .findFirst());
    }
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3296#issuecomment-533166160
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190919/be682866/attachment.html>


More information about the bisq-github mailing list