[bisq-network/bisq-website] Refactoring in preparation for the new localization system (#256)

Steve Jain notifications at github.com
Mon Sep 23 13:42:56 UTC 2019


@erciccione great to see this moving forward. Content looks good to me.

The front page has an issue with the background, possibly related with the change in the default template.

See PR on the left and master on the right:

![Screenshot from 2019-09-23 09-28-40](https://user-images.githubusercontent.com/735155/65430518-166d7700-dde6-11e9-9c3e-236f1db9709e.png)

Also different spacing on mobile (probably related):

![Screenshot from 2019-09-23 09-35-24](https://user-images.githubusercontent.com/735155/65430529-1b322b00-dde6-11e9-956d-e58b9fd0d631.png)

Also, I appreciate your detailed commit messages, but please follow [these 7 rules](https://github.com/bisq-network/style/issues/9#issue-319178416). In particular, keep the subject line under 50 characters and the first word a verb in imperative form.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-website/pull/256#issuecomment-534104641
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190923/43c882c9/attachment.html>


More information about the bisq-github mailing list