[bisq-network/bisq] List BitcoinV (BTCV) (#3252)

Bernard Labno notifications at github.com
Mon Sep 30 04:56:45 UTC 2019


blabno requested changes on this pull request.

NACK per comments.

> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.asset.coins;
+
+import bisq.asset.Base58BitcoinAddressValidator;
+import bisq.asset.Coin;
+
+import org.bitcoinj.core.NetworkParameters;
+import org.bitcoinj.params.MainNetParams;
+
+public abstract class BitcoinV extends Coin {

No need for abstraction here. Make this class use mainnet (default params).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3252#pullrequestreview-294749696
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190929/5427f1b6/attachment.html>


More information about the bisq-github mailing list