[bisq-network/bisq] start testing the wallet services (#3326)

[Christoph Sturm]

christophsturm commented on this pull request.



> +import bisq.core.user.Preferences;
+import bisq.core.util.ParsingUtils;
+
+import org.bitcoinj.core.Coin;
+import org.bitcoinj.params.UnitTestParams;
+import org.bitcoinj.utils.MonetaryFormat;
+import org.bitcoinj.wallet.Wallet;
+
+import org.junit.Test;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class BsqWalletServiceTest {
+    @Test(expected = InsufficientBsqException.class)
+    public void throwsExceptionWhenFundsAreInsufficient() throws TransactionVerificationException, WalletException, BsqChangeBelowDustException, InsufficientBsqException {

I don't really like that style and I think it adds nothing. actually any comment in a test is a code smell. 
Personally I use https://github.com/dmcg/minutest for my own work, thats nice and expressive. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3326#discussion_r329696319
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190930/fdb386c2/attachment.html>