[bisq-network/bisq] Add BuyerVerifiesDonationAddress task (#4131)

burningman2 notifications at github.com
Tue Apr 7 23:17:42 UTC 2020

Buyer was not verifying if the donation address is either the default
DAO param address or the recent one changed by DAO voting. We do not
support past DAO param addresses to avoid that past addresses receive

- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".

Fixes #replaceWithIssueNr, fixes #replaceWithIssueNr

Your PR description here.

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * Add BuyerVerifiesDonationAddress task

-- File Changes --

    M core/src/main/java/bisq/core/trade/protocol/BuyerAsMakerProtocol.java (2)
    M core/src/main/java/bisq/core/trade/protocol/BuyerAsTakerProtocol.java (2)
    A core/src/main/java/bisq/core/trade/protocol/tasks/buyer/BuyerVerifiesDonationAddress.java (80)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200407/65f3f8e6/attachment.html>

More information about the bisq-github mailing list