[bisq-network/bisq] [WIP] Add list to filter to set btc fee receiver addresses (#4150)

chimp1984 notifications at github.com
Wed Apr 8 23:07:51 UTC 2020


This adds support for distributing trade fees in BTC to a list of addresses defined in the Filter object. The Filter can be set dynamically via the P2P network so it is a fast tool to adjust once the list should be altered. In case no values are provided or the user has not updated the default donation address from the DAO param is used.

This might be an option how we can handle the losses of the victims from the recent security issue. If the idea finds support among Bisq contributors and is accepted by the victims this would be a way how they get reimbursed over a period of time from the trade fees paid by users who use BTC instead of BSQ.  

The selection is a simple random selection, so it would benefit those victims with smaller losses to get refunded earlier. We could alter the algorithm by using the index in the list as weight, so the first items have higher chances to get selected and thus create a more fair payout schedule. I leave this for a future addition if the idea finds support.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4150

-- Commit Summary --

  * Add list to filter to set btc fee receiver addresses

-- File Changes --

    M core/src/main/java/bisq/core/filter/Filter.java (19)
    M core/src/main/java/bisq/core/offer/OpenOfferManager.java (7)
    M core/src/main/java/bisq/core/offer/placeoffer/PlaceOfferModel.java (7)
    M core/src/main/java/bisq/core/offer/placeoffer/tasks/CreateMakerFeeTx.java (5)
    M core/src/main/java/bisq/core/trade/protocol/tasks/taker/CreateTakerFeeTx.java (6)
    A core/src/main/java/bisq/core/util/FeeReceiverSelector.java (47)
    M core/src/main/resources/i18n/displayStrings.properties (1)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/FilterWindow.java (5)
    M proto/src/main/proto/pb.proto (1)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4150.patch
https://github.com/bisq-network/bisq/pull/4150.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4150
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200408/314ae613/attachment-0001.html>


More information about the bisq-github mailing list