[bisq-network/bisq] Not on FX application thread exception at shut down (#4148)
notifications at github.com
Thu Apr 9 06:10:33 UTC 2020
I don't think my PR (https://github.com/bisq-network/bisq/pull/4122) to change the behaviour of `UserThread` has been merged yet, at least not into master. However, it does include a change to `OpenOfferManager` which should fix the above exception.
It looks like it was an unrelated change (to prevent a lockup on shutdown) on the 26th of March which replaced `UserThread.runAfter(..)` with `new Thread(..).start()` in BisqApp.java:153.
BTW, I noticed during testing of the above PR that a lockup-on-shutdown problem still exists when there are open offers, as the relevant branch of `OpenOfferManager.shutDown` passes the `completeHandler` continuation to `UserThread::runAfter` instead of executing it directly in the new thread created in `BisqApp`. I wasn't quite sure the best way to fix the issue at the time, as I'm not very familiar with that area of the code, so I left it.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the bisq-github