[bisq-network/bisq] Limit abuse of `--useLocalhostForP2P` option (#4154)

[Florian Reimair]

<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->

Fixes https://github.com/bisq-network/bisq/issues/4152, fixes https://github.com/bisq-network/bisq/issues/4123, fixes https://github.com/bisq-network/bisq/issues/3927

Until now, the `--useLocalhostForP2P` option could be used even for `BTC_MAINNET`. Even though the option has been clearly labelled to be for development purposes, it found its way into setup guides for eg. the Tails OS.

This PR only allows the option if the base currency network is set to something other than `BTC_MAINNET`.

That of course will most likely prevent users on Tails OS to use Bisq. Will look into the Tails stuff soon and followup on this one.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4154

-- Commit Summary --

  * Limit abuse of useLocalhostForP2P option

-- File Changes --

    M common/src/main/java/bisq/common/config/Config.java (5)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4154.patch
https://github.com/bisq-network/bisq/pull/4154.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4154
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200409/3d6c0bd8/attachment.html>