[bisq-network/bisq] Limit abuse of `--useLocalhostForP2P` option (#4154)

Christoph Atteneder notifications at github.com
Fri Apr 10 10:08:47 UTC 2020


@ripcurlx approved this pull request.

ACK

Tested it on Regtest with different scenarios:
- Not passing a `BASE_CURRENCY_NETWORK` and using `USE_LOCALHOST_FOR_P2P` fails with
`error: problem parsing option 'useLocalhostForP2P': Option(s) [useLocalhostForP2P] are unavailable given other options on the command line`
- Setting Mainnet as base currency network defaults `USE_LOCALHOST_FOR_P2P` to false.
- Setting Regtest as base currency network still allows `USE_LOCALHOST_FOR_P2P` to get set.






-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4154#pullrequestreview-391370122
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200410/35d95c92/attachment.html>


More information about the bisq-github mailing list