[bisq-network/bisq] When accepting an offer do not round the BTC amount outside range (#4178)

James Cox notifications at github.com
Sat Apr 18 03:16:22 UTC 2020


Fixes #3871.  The BTC amount of an offer was being adjusted up in certain cases due to a rounding calculation from the fiat value and price.  This would prevent some offers from being taken.

There's an existing check to ensure that the amount is not adjusted below the minimum, here we add a check to ensure that the amount is not adjusted higher than the maximum defined in the offer.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4178

-- Commit Summary --

  * When accepting an offer do not round the BTC amount outside range

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferViewModel.java (8)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4178.patch
https://github.com/bisq-network/bisq/pull/4178.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4178
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200417/e5fc8795/attachment-0001.html>


More information about the bisq-github mailing list