[bisq-network/bisq] Editing an offer should not allow the BTC amount to be changed (#4182)

[James Cox]

### TEST - Editing an offer should not change the BTC amount due to rounding.

Setup - Using bisq **prior to the fix**.

- Create and save an offer to sell 0.0625 BTC for a price of 7500 (469 USD)
- Go to Open Offers and click on the edit icon
- Verify that the edit dialog shows 0.0625 BTC and price of 7500 (469 USD)
- Change the price to 7400 and press tab.  The amount of BTC changes to 0.0626 (463 USD)
- Change the price to 1111 and press tab.  The amount of BTC changes to 0.0630 (70 USD)
- Change the price to 1024 and press tab.  The amount of BTC changes to 0.0635 (65 USD)
- Change the price to 7400 and press tab.  The amount of BTC remains at 0.0635 (470 USD)
- Save the offer.
- It is now a sell of 0.0635 at 7400 (470 USD).
- The BTC amount has changed from 0.0625 to 0.0635 when you only wanted to edit the price of the offer.  Bug.


Setup - Using bisq **incorporating this fix**.

- Create and save an offer to sell 0.0625 BTC for a price of 7500 (469 USD)
- Go to Open Offers and click on the edit icon
- Verify that the edit dialog shows 0.0625 BTC and price of 7500 (469 USD)
- Change the price to 7400 and press tab.  The amount of BTC remains 0.0625 (463 USD)
- Change the price to 1111 and press tab.  The amount of BTC remains 0.0625 (69 USD)
- Change the price to 1024 and press tab.  The amount of BTC remains 0.0625 (64 USD)
- Change the price to 7400 and press tab.  The amount of BTC remains 0.0625 (463 USD)
- Save the offer.
- It is now a sell of 0.0625 at 7400 (463 USD).
- The BTC amount has remained the same, you've changed the price and the resultant USD amount.  This is good.
 

*These examples use USD but it works the same using EUR or other currencies.*


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4182#issuecomment-616168218
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200419/e115ee2a/attachment.html>