[bisq-network/bisq] Maker errors with 'Insufficient money', Taker errors with 'deposit is null' and timeout (#2293)

[James Cox]

A reproducible way to encounter this problem is as follows (from #3871):

- Create and save an offer to sell 0.05 BTC for a price of 6400
- Go to Open Offers and click on the edit icon
- Change the price to 6452.3042 and press tab.  The amount of BTC changes to 0.0501
- Save the offer.


When the offer is taken, the maker gets "Insufficient money, missing 0.0001 BTC".  The missing amount corresponds to the amount that BTC got adjusted by when editing the offer.
PR #4182 fixes this particular example by preventing the BTC amount of the offer from being adjusted.  

Whether there is another scenario for encountering this "Insufficient money" error remains to be seen.  I suspect there still might be, since in the OP's second example the missing amount is 0.01046 which is 5 decimals whereas offers always limit BTC amounts to 4 decimals.  Perhaps another way to encounter this would be if the offer's `reserved funds` were spent before the offer is taken.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/2293#issuecomment-616920070
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200420/7f6dad5f/attachment.html>