[bisq-network/bisq] Implement simple cleartext gRPC authentication (#4189)

Chris Beams notifications at github.com
Thu Apr 23 15:50:16 UTC 2020

@ghubstan the inability to push was an issue on my side with my local `.git/hooks`. I've solved it for the time being and pushed up my current set of commits. You'll see the last few are still in a WIP state, so please don't build anything on top of this just yet.

It's worth looking through each of the commits, in some of them I've explained exactly why changes were made.

Overall, though, the idea is to radically simplify things. One of the main purposes of the cli is to serve as a reference client for working with Bisq's rpc api, and as such it should be dead simple to understand. It's probably a bit _too_ simple now, I would do some additional refactoring to reduce certain redundant code, but I wouldn't go very far here. The implementation will certainly need to get more sophisticated as we go implementing all the endpoints, but we can do that on an as-needed basis.

Hope this helps / makes sense. Let me know if you have questions / feedback. It might be a little bit before I get back to this, Monday possibly.

By the way, here's how you can invoke `bisq-cli` now:

    ./bisq-cli -auth=mytoken getversion

Where `mytoken` was provided on the bisqd side as:

    ./bisq-daemon --apiToken=mytoken

The `apiToken` naming will change further, it's still WIP, but as you can see, rpcuser / rpcpassword are out of the picture now (and can return to their existing use for talking to bitcoind).

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200423/8791d55b/attachment.html>

More information about the bisq-github mailing list