[bisq-network/bisq] QR code not matching BTC amount when using BSQ for trading fee (#4194)

[James Cox]

@eigentsmis good find!  Adding a few extra relevant pieces of information here:

- this issue seems to have been around for a while.  Screenshot below shows it in v1.2.9
- it also happens using BTC for the fee (not only BSQ), as shown below.
- if you click on the small QR code there is an enlarged QR code shown which has the correct amount (see second screenshot below)
- initial thoughts as to the cause is that the small QR code is initialized on offer creation, but does not listen to changes from the data model like the other fields.  The fees are calculated asynchronously on a different thread causing the data model / amount to be updated, but the QR code does not recieve that updated value.


### offer creation, QR code for incorrect amount:

![image](https://user-images.githubusercontent.com/47253594/80260106-c640e680-864c-11ea-8087-0e67dc70745a.png)

### same offer, larger QR code, correct amount:

![image](https://user-images.githubusercontent.com/47253594/80261250-84fe0600-864f-11ea-8d10-b3985c3aa133.png)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/4194#issuecomment-619262646
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200424/fac28a08/attachment.html>