[bisq-network/bisq] Fix Trader Chat row selection and unread message count (#4195)

James Cox notifications at github.com
Sat Apr 25 13:47:39 UTC 2020


Clicking on the trader chat icon of a trade that is not selected should select that row in the trade list. It does not. This causes confusion as it gives misleading cues as to which trader you are
communicating with. Issue a call to select the row of the button when clicked.

The trader chat view can be opened either by clicking on the chat icon of a trade in the list, or clicking on "OPEN TRADER CHAT" button for the currently displayed trade.  In the latter case, the count of new messages displayed on the chat icon was not cleared even though trader chat was shown.  The solution is to move the scope of the routine that updates trader chat message count from within the table cell handler to the PendingTradesView class so that it can be called whenever
onChat() is invoked (i.e. when the Trader Chat screen is shown).

Fixes bisq-network#4172
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4195

-- Commit Summary --

  * Fix an issue whereby the unread chat message count was not cleared properly
  * Select current row when user clicks on trader chat icon

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java (41)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4195.patch
https://github.com/bisq-network/bisq/pull/4195.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4195
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200425/addbdadb/attachment.html>


More information about the bisq-github mailing list