[bisq-network/bisq] Implement simple cleartext gRPC authentication (#4189)

Chris Beams notifications at github.com
Sun Apr 26 09:09:42 UTC 2020


@cbeams requested changes on this pull request.

I am unable to reproduce the failure you're talking about. Neither `./bisq-cli --password="foo bar" getversion` nor `./gradlew :cli:run --args='--password="foo bar" getversion'` causes any issue for me, i.e. the double quotes are handled properly by JOptSimple, and it appears to me that the code you've added is unnecessary. What is the repro case for you?



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4189#pullrequestreview-400479517
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200426/f40dd7e9/attachment.html>


More information about the bisq-github mailing list