[bisq-network/bisq] Implement wallet protection rpc methods (#4198)

Chris Beams notifications at github.com
Mon Apr 27 17:45:21 UTC 2020


Thanks, @ghubstan. I've updated the title to better reflect what needs to happen here. The core task is implementing wallet protection rpc methods, and as the rpc reference client (and hopefully as a useful tool), we always support new rpc methods in the cli.

I also removed the Description section from the description above, as it's redundant (I know it's part of the issue template, but is intended more for bug reporting, not a feature request issue like this one. Likewise, I removed the Version section as well, as its intent is for reporting the version of Bisq affected by a given bug being reported. Whether or not this change will make it into v1.3.3 remains to be seen.

I'll see about getting our previous PR merged asap, so that I can push my changes on the rpc server side. You said in another chat that you're going to work on the bats conversion first, that's will buy a little time (and should be its own PR separate from the one dealing with implementing these new methods). But if you do start working on the server side implementation of these new methods, please be aware that we'll have merge conflicts if you don't build on top of my changes. Again, they're in my `refactor-rpc-server` branch. I'll get them pushed up to a PR soon.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/4198#issuecomment-620133527
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200427/0a3a17fa/attachment-0001.html>


More information about the bisq-github mailing list