[bisq-network/bisq] Add rpc wallet protection endpoints (#4214)

Stan notifications at github.com
Wed Apr 29 22:44:14 UTC 2020


Implemented `lockwallet`, `unlockwallet`, `removewalletpassword`, and `setwalletpassword` methods with basic error handling.

Also added basic error handling to the existing `getbalance` method, and removed unused `BalancePresentation` from `CoreAPI`.

TODO:  update :cli help text

Parital fix for #4198

#### Notes

I didn't spend time second-guessing maintainers about the ordering of rpc service defs & methods in grpc.proto and GrpcServer, so changes might need to be made in that regard.  It makes sense to group wallet protection related methods together, but that is inconsistent with other alphabetically ordered service and method names.

There is also a `getbalance` error handling bug that needs fixing:  `Error: null` is printed to the :cli console when the daemon  is losing peers (SOCKET_TIMEOUT).

Bats test cases for these methods are ready to push in a new PR after (if) [4209](https://github.com/bisq-network/bisq/pull/4209) is merged.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4214

-- Commit Summary --

  * Add rpc wallet protection endpoints

-- File Changes --

    M cli/src/main/java/bisq/cli/CliMain.java (89)
    M core/src/main/java/bisq/core/grpc/CoreApi.java (125)
    M core/src/main/java/bisq/core/grpc/GrpcServer.java (67)
    M proto/src/main/proto/grpc.proto (74)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4214.patch
https://github.com/bisq-network/bisq/pull/4214.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4214
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200429/864b4609/attachment.html>


More information about the bisq-github mailing list