[bisq-network/bisq] Reject expired data (#4215)

[chimp1984]

If a new received protectedStorageEntry is expired we do not store it
and do not broadcast.

It is unclear why we receive expired data (some are very old), but a
manipulated node might produce that and as it only removed at each
batch process running each minute to clean out expired data it still
could propagate. Is an attack vector also to flood the network with
outdated offers where the maker is likely not online.

Should fix https://github.com/bisq-network/bisq/issues/4026
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4215

-- Commit Summary --

  * If a new received protectedStorageEntry is expired we do not store it

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBook.java (2)
    M p2p/src/main/java/bisq/network/p2p/storage/P2PDataStorage.java (36)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4215.patch
https://github.com/bisq-network/bisq/pull/4215.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4215
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200429/40f28db3/attachment.html>