[bisq-network/bisq] PriceNode: Add support for multiple ExchangeRateProviders (#4315)

[cd2357]

> I installed your PR branch and it crashes on startup, you owe me a thousand bucks 😁

It failed cause BitcoinAverage didn't find the API keys. I kind of assumed the PR would be used to upgrade a current pricenode, or at least using the same environment setup (e.g. including the BA keys). But of course, if it's used without the API keys, it will fail.

So alright, kind of a gray area -- I wasn't clear enough on this in the bounty rules. But I guess that's on me, lesson learned :)

So sure, you get the bounty :) We'll settle this once the compensation is out.

> Can you just delete the Bitcoin Average provider?

Will do, commit coming soon.

> But obviously a 404 error should not cause the pricenode to crash, this is also why CMC returning 410 a while ago caused our pricenodes to crash. It seems this critical exception is not handled?

Yea and no. This failure is specific to the BA setup, which expects to find an API key, otherwise it won't start up.

If the pricenode is running (started fine), but then some API endpoint returns errors, that should be handled (see Test 5).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4315#issuecomment-668736594
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200804/43086d1b/attachment.html>