[bisq-network/bisq] [WIP] Split trade statistics between recent data and historical data (#4405)

[sqrrm]

@sqrrm commented on this pull request.

This implementation throws away all old tradestats data and doesn't allow for any historical lookup. What is the plan for allowing historical data?

Instead of throwing data away during pruning it should probably be stored locally as HistoricalTradeStats which would work a bit like the split stores in https://github.com/bisq-network/bisq/pull/4233 except it's not a fixed block, but rather an append store but it can be excluded for all non historical data requests to seeds.

> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.network.p2p.storage.payload;
+
+import bisq.common.Payload;
+
+/**
+ * Interface for PersistableNetworkPayloads which can be pruned (e.g. old objects will be removed from data store).
+ */
+public interface PrunablePersistableNetworkPayload extends Payload {

Is there a reason to not let this inherit from `PersistableNetworkPayload`? That would make more sense to me.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4405#pullrequestreview-463793592
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200808/eafc56de/attachment.html>