[bisq-network/bisq] PriceNode: Add support for multiple ExchangeRateProviders (#4315)

[sqrrm]

@sqrrm commented on this pull request.

Overall this looks good to me.

Requiring Java 11 is likely not a problem as we're never shipping this, all price node operators build from source. I can't see any other issues with that either, but still worth keeping in mind.

There are still heaps of codacy complaints. Some seem legit, some are probably just settings that are too strict.

> @@ -57,7 +57,7 @@ configure(subprojects) {
         junitVersion = '4.12'
         jupiterVersion = '5.3.2'
         kotlinVersion = '1.3.41'
-        knowmXchangeVersion = '4.3.3'
+        knowmXchangeVersion = '4.4.2'

New import, haven't seen any mention of this in the discussion. Anything new carries a risk, and perhaps more so when upgrading versions as the project in question already knows it's being used by bisq. In this case this is for price nodes so bisq wallets are not affected, lowering the risk.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4315#pullrequestreview-463795938
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200808/f0a64fdc/attachment.html>