[bisq-network/bisq] [WIP] Autoconfirm XMR trade if tx check was validated by proof service (using tx private key) (#4378)

[James Cox]

Thanks for the feedback - the complexities you mentioned were my mis-interpreting the requirements.  I have changed them to simplify, `proto` now looks like this:

    message AutoConfirmSettings {
        bool enabled = 1;
        int32 confirm_blocks = 2;
        int64 trade_limit = 3;
        repeated string service_addresses = 4;
    }

Settings GUI looks like this:
![image](https://user-images.githubusercontent.com/47253594/90074152-38067400-dcc0-11ea-8232-4a9f93275c79.png)


Not sure how worth-while it will be to implement other alt-coins since they are barely traded and the overhead in addition to coding would be for ops to run trusted explorer APIs & blockchains for each coin.  For now I opted to keep it simple especially with the GUI: just autoconf for XMR.

Thanks to @moneroexamples the API now includes the confirmation count so Bisq app waits until the relevant number have been received.  @Emzy if you have time, could you update to the latest master branch of `onion-monero-blockchain-explorer`?  The test API service has been incredibly useful, I've been using it to check the scenario of multiple API providers.

Code checked into [my branch](https://github.com/jmacxx/bisq/tree/add-xmr-tx-key-service) is functional but still needs cleaning up:
- [ ] strings need to be put into displayStrings.properties
- [ ] indication on final trade step screen needs improving
- [ ] need some way to hardcode known providers addresses similar to what is done with price and fees APIs

I will continue to address the above, just wanted to post the progress update.  At this point it is functionally ready to be tried out or reviewed if anyone wishes to do so.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4378#issuecomment-673143019
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200812/f28634e4/attachment.html>