[bisq-network/bisq] Add API test harness for Linux & OSX (#4366)

dmos62 notifications at github.com
Thu Aug 13 12:09:34 UTC 2020


@dmos62 commented on this pull request.



> @@ -55,6 +55,7 @@ public void start() throws InterruptedException, IOException {
                 + " -txindex=1"
                 + " -peerbloomfilters=1"
                 + " -debug=net"
+                + " -fallbackfee=0.0002"

Oh wait. This bitcoind will never run in mainnet, will it? Then the concern is that the apitest testing harness will have a different bitcoind environment than a production daemon would.

Again, I don't fully understand the significance of the `fallbackfee` option. It's used when the bitcoind can't estimate a "floating fee", right? And it only applies when sending funds from a wallet managed by the bitcoind instance, right? If both answers are yes, then I don't see this causing differences between prod and dev environments, but I'd like someone else to sanity check this too.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4366#discussion_r469903365
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200813/df021e55/attachment.html>


More information about the bisq-github mailing list