[bisq-network/bisq] Add API test harness for Linux & OSX (#4366)

dmos62 notifications at github.com
Thu Aug 13 17:09:18 UTC 2020


@dmos62 commented on this pull request.



> @@ -40,9 +39,12 @@ public BitcoinCliHelper(ApiTestConfig config) {
 
     public String getNewBtcAddress() {
         try {
-            String newAddress = new BitcoinCli(config, "getnewaddress").run().getOutput();
-            assertNotNull(newAddress);
-            return newAddress;
+            BitcoinCli newAddress = new BitcoinCli(config, "getnewaddress").run();
+
+            if (newAddress.isError())
+                fail(format("Could generate new bitcoin address:%n%s", newAddress.getErrorMessage()));

Typo? "Could _not_ generate ..."?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4366#pullrequestreview-466969014
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200813/f8083741/attachment.html>


More information about the bisq-github mailing list