[bisq-network/bisq] Move gRPC boilerplate from :core to :daemon (#4417)
Stan
notifications at github.com
Wed Aug 19 18:53:15 UTC 2020
This change moves gRPC boilerplate classes from the `:core.grpc` pkg into a new `:daemon.grpc` pkg.
* The `:core.grpc `pkg was renamed `:core.api`, and no longer has any dependencies on `gRPC` libraries.
* All core service classes in the `:core.api` pkg were made package protected, excepting `CoreApi`, making `CoreApi` the only possible entry point for all `Grpc*Service` -> -`Core*Service` calls.
* All `Grpc*Service` classes in the `:daemon.grpc` pkg were made package protected, excepting `GrpcServer`; the only class depending on the Grpc*Service classes is GrpcServer.
* gRPC dependencies were moved from the `gradle.build` file's `:core` sub-project to `:daemon`.
No changes were made to `apitest`, but this PR's branch is based on the [PR 4366](https://github.com/bisq-network/bisq/pull/4366) branch, so [PR 4366](https://github.com/bisq-network/bisq/pull/4366) ought to be merged before this one.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/4417
-- Commit Summary --
* Add configuration support
* Add main resource files
* Add script to get Bisq app pid
* Support starting bitcoin & bisq apps on Linux
* Add :apitest main driver, setup task & dummy tests
* Add build tasks for installing dao-setup files
* Add subproject :apitest to gradle build file
* Fix codacy problems
* Fix codacy problems
* Fix codacy problem
* Fix error msg spacing
* Fix error msgs
* Remove MaxRAM from DEFAULT_JVM_OPTS
* Assume bitcoin-core is statically linked to berkeley-db
* Fix hanging background process problem
* Add line break in front of port config
* Move test setup scaffolding into new Scaffold class
* Expose grpc service stubs
* Fix codacy problems
* Fix codacy problem
* Support @Skip on test classes and methods
* Add first method test cases
* Add MethodTestSuite
* Update bats version test
* Make init() method public
* Add license note, format tearDown(), fix comment
* Run MethodTestSuite
* Add license note
* Fix codacy problem
* Delete commented statement
* Do not run dummy test from driver
* Fix varible names
* Remove test scaffolding logic from ApiTestConfig
* Refresh dao-setup files in Scaffold setup
* Remove hacked method tests
* Support @Order-ing of JUnit tests
* Add first JUnit 'method' tests
* Add driver for running method tests
* Get rid of references to removed @Skip annotation
* Remove @Skip annotaion
* Fix codacy problem in bash script
* Replace config 'numSetupTasks' with 'supportingApps'
* Allow more time for background app shutdown
* Refactor ApiTestCase class hierarchy
* Add wallet protect method tests
* Add tests for resetting a wallet password
* Add --bisqAppInitTime=<Long> config option
* Fix hardcoded bitcoin.conf property values
* Fix comment and code styling
* Fix 'bitcoind not found' error message
* Delete throws clause from method signature
* Fix bitcoind startup error handling
* Bump bisqAppInitTime default back up to 5s
* Remove all sudo related logic from the linux pkg
* Do not "killall bitcoind" processes
* Create convenient way to call bitcoin-cli from tests
* Add FundWalletScenarioTest
* Add JUnitHelper to run tests from JUnitCore
* Do not subtract fee from 'bitcoin-cli sendtoaddress'
* Remove final modifier
* Do not use bitcoin.conf files
* Delete unused bitcoin.conf from resources dir
* Delete all JUnit related class from main sources
* Moving GrpcStubs to test sources
* Move test cases into subproject test sources
* Change :apitest:test task system property name
* Add comment about Bisq DAO dev environment
* Fix @BeforeClass error handling and use jupiter api
* Remove unnecessary curly braces
* Change 'missing bitcoind path' error msg
* Do not leave orphaned processes after failed teardown
* Remove extra whiteline
* Clarify scaffold tear down error handling
* Add fallbackfee param to bitcoind start cmd
* Fix BitcoinCli wrapper error handling
* Fix test fail() msg
* Use non-default regtest bitcoind -rpcport
* Add regtest-port-conflicts.md doc
* Fix port number typo
* Add build / run / test categories docs
* Explain how to run test cases from Intellij
* Fix typo
* Update README
* Remove white lines
* Add punctuation & re-phrase sentence in README
* Change access modifer
* Put 'empty' comments inside ignored catch blocks
* Move gRPC boilerplate from :core to :daemon
-- File Changes --
A apitest/dao-setup.gradle (83)
A apitest/docs/README.md (5)
A apitest/docs/build-run.md (68)
A apitest/docs/regtest-port-conflicts.md (12)
A apitest/docs/test-categories.md (35)
A apitest/scripts/get-bisq-pid.sh (15)
A apitest/src/main/java/bisq/apitest/ApiTestMain.java (80)
A apitest/src/main/java/bisq/apitest/Scaffold.java (417)
A apitest/src/main/java/bisq/apitest/SetupTask.java (85)
A apitest/src/main/java/bisq/apitest/SmokeTestBashCommand.java (51)
A apitest/src/main/java/bisq/apitest/SmokeTestBitcoind.java (72)
A apitest/src/main/java/bisq/apitest/config/ApiTestConfig.java (370)
A apitest/src/main/java/bisq/apitest/config/BisqAppConfig.java (123)
A apitest/src/main/java/bisq/apitest/config/CompositeOptionSet.java (61)
A apitest/src/main/java/bisq/apitest/linux/AbstractLinuxProcess.java (131)
A apitest/src/main/java/bisq/apitest/linux/BashCommand.java (156)
A apitest/src/main/java/bisq/apitest/linux/BisqApp.java (263)
A apitest/src/main/java/bisq/apitest/linux/BitcoinCli.java (182)
A apitest/src/main/java/bisq/apitest/linux/BitcoinDaemon.java (117)
A apitest/src/main/java/bisq/apitest/linux/LinuxProcess.java (42)
A apitest/src/main/java/bisq/apitest/linux/SystemCommandExecutor.java (121)
A apitest/src/main/java/bisq/apitest/linux/ThreadedStreamHandler.java (91)
A apitest/src/main/resources/apitest.properties (0)
A apitest/src/main/resources/blocknotify (20)
A apitest/src/main/resources/logback.xml (21)
A apitest/src/test/java/bisq/apitest/ApiTestCase.java (94)
A apitest/src/test/java/bisq/apitest/GrpcStubs.java (109)
A apitest/src/test/java/bisq/apitest/JUnitHelper.java (58)
A apitest/src/test/java/bisq/apitest/method/BitcoinCliHelper.java (92)
A apitest/src/test/java/bisq/apitest/method/GetBalanceTest.java (68)
A apitest/src/test/java/bisq/apitest/method/GetVersionTest.java (61)
A apitest/src/test/java/bisq/apitest/method/MethodTest.java (88)
A apitest/src/test/java/bisq/apitest/method/WalletProtectionTest.java (135)
A apitest/src/test/java/bisq/apitest/scenario/FundWalletScenarioTest.java (68)
A apitest/src/test/java/bisq/apitest/scenario/ScenarioTest.java (28)
M build.gradle (105)
M cli/src/main/java/bisq/cli/CurrencyFormat.java (2)
M cli/test.sh (4)
R core/src/main/java/bisq/core/api/CoreApi.java (4)
R core/src/main/java/bisq/core/api/CoreOffersService.java (4)
R core/src/main/java/bisq/core/api/CorePaymentAccountsService.java (4)
R core/src/main/java/bisq/core/api/CoreWalletsService.java (4)
R core/src/main/java/bisq/core/api/model/AddressBalanceInfo.java (2)
R core/src/main/java/bisq/core/api/model/OfferInfo.java (2)
M daemon/src/main/java/bisq/daemon/app/BisqDaemonMain.java (7)
R daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java (5)
R daemon/src/main/java/bisq/daemon/grpc/GrpcPaymentAccountsService.java (5)
R daemon/src/main/java/bisq/daemon/grpc/GrpcServer.java (3)
R daemon/src/main/java/bisq/daemon/grpc/GrpcWalletsService.java (5)
R daemon/src/main/java/bisq/daemon/grpc/PasswordAuthInterceptor.java (2)
M settings.gradle (1)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/4417.patch
https://github.com/bisq-network/bisq/pull/4417.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4417
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200819/e0bcd4b8/attachment-0001.html>
More information about the bisq-github
mailing list